-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: add mocha.mjs export #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
For now let's exclude the private keys, they shouldn't be necessary for this export. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5527 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 57 57
Lines 4391 4391
Branches 850 850
=======================================
Hits 4114 4114
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the review! I saw the linting failed after the merge, so I added my addition of |
|
Fixed the build error, but not sure how to manually test this one. Going to unassign myself as this isn't a focus area for me compared to bugfixes and the v12 release, but hopefully after v12 we can come back to this. Thanks for getting this started and continuing to follow up! |
PR Checklist
status: accepting prsOverview
Adds an ESM export file for use in the browser.
The other non-underscored (private) keys I saw on the global
mochaobject which I wasn't sure which I might include were the following:files,options,suite,isWorker,throwError,ui